Add to the PKIX name: Country, State/Province, Locality, Street Addre… #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss, Postal Code. Fixes hashicorp#3777
jefferai
reviewed
Jan 15, 2018
| }, | ||
|
|
||
| "province": &framework.FieldSchema{ | ||
| Type: framework.TypeString, |
There was a problem hiding this comment.
Please use TypeCommaStringSlice and store the values as []string.
jefferai
reviewed
Jan 15, 2018
| "street_address": &framework.FieldSchema{ | ||
| Type: framework.TypeString, | ||
| Default: "", | ||
| Description: `If set, the streetAddress will be set to |
There was a problem hiding this comment.
Please don't CamelCase streetAddress/postalCode.
|
Obsoleted by #3992, thanks though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to use the Vault PKI Secret backend to generate certs and found that it didn't support the Country, State/Province and Locality fields.
I added those, and thought of adding Street Address and Postal Code as well since they are supported by the Go crypto.x509.pkix.Name.
Fixes #3777